Here is my first comments:
http://codereview.chromium.org/8700008/diff/9001/src/ia32/full-codegen-ia32.cc File src/ia32/full-codegen-ia32.cc (right): http://codereview.chromium.org/8700008/diff/9001/src/ia32/full-codegen-ia32.cc#newcode136 src/ia32/full-codegen-ia32.cc:136: info->function()->is_primitive() && What is a primitive function? I can't find the source code for this predicate. http://codereview.chromium.org/8700008/diff/9001/src/objects.h File src/objects.h (right): http://codereview.chromium.org/8700008/diff/9001/src/objects.h#newcode5464 src/objects.h:5464: inline int profiler_ticks(); Shouldn't be this on SharedFunctionInfo instead? http://codereview.chromium.org/8700008/diff/9001/src/runtime-profiler.cc File src/runtime-profiler.cc (left): http://codereview.chromium.org/8700008/diff/9001/src/runtime-profiler.cc#oldcode59 src/runtime-profiler.cc:59: static const int kSizeLimit = 1500; The reason for looking at the size in some form was that large functions are more expensive to optimize, so we want to be sure they're worth optimizing by requiring more profiler ticks. The metric used is maybe not ideal, but some form of taking size into account would be still useful. It seemed to help on ia32. http://codereview.chromium.org/8700008/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
