http://codereview.chromium.org/8700008/diff/9001/src/ia32/full-codegen-ia32.cc File src/ia32/full-codegen-ia32.cc (right):
http://codereview.chromium.org/8700008/diff/9001/src/ia32/full-codegen-ia32.cc#newcode135 src/ia32/full-codegen-ia32.cc:135: if (FLAG_crankshaft && If a function has optimization disabled via DisableOptimization() because we can't optimize it or we deoptimized frequently, we should not add code for counting. http://codereview.chromium.org/8700008/diff/9001/src/objects.h File src/objects.h (right): http://codereview.chromium.org/8700008/diff/9001/src/objects.h#newcode5464 src/objects.h:5464: inline int profiler_ticks(); On 2011/12/12 11:31:21, fschneider wrote:
Shouldn't be this on SharedFunctionInfo instead?
This increases the size of each JSFunction by 1 word from 36 to 40 (11%). This could hurt memory-constrained devices on programs with lots of closures. I'd prefer a solution without additional space cost. http://codereview.chromium.org/8700008/diff/9001/src/runtime-profiler.cc File src/runtime-profiler.cc (right): http://codereview.chromium.org/8700008/diff/9001/src/runtime-profiler.cc#newcode82 src/runtime-profiler.cc:82: PrintF(" for recompilation, reason: %d", reason); Print reason in English instead of just a number. http://codereview.chromium.org/8700008/diff/9001/src/runtime-profiler.cc#newcode163 src/runtime-profiler.cc:163: Optimize(function, 1); Name instead of an integer constant? http://codereview.chromium.org/8700008/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
