http://codereview.chromium.org/8971002/diff/3001/src/ia32/disasm-ia32.cc File src/ia32/disasm-ia32.cc (right):
http://codereview.chromium.org/8971002/diff/3001/src/ia32/disasm-ia32.cc#newcode465 src/ia32/disasm-ia32.cc:465: return 1; what kind of warning do you get here? this return can never be reached (cases end with return, and default captures everything else). seems like a bug in the compiler. http://codereview.chromium.org/8971002/diff/3001/src/ic.cc File src/ic.cc (right): http://codereview.chromium.org/8971002/diff/3001/src/ic.cc#newcode625 src/ic.cc:625: return Handle<Code>::null(); ditto. what does compiler say? this can never be reached both branches of the if statement end with returns. http://codereview.chromium.org/8971002/diff/3001/src/x64/disasm-x64.cc File src/x64/disasm-x64.cc (right): http://codereview.chromium.org/8971002/diff/3001/src/x64/disasm-x64.cc#newcode551 src/x64/disasm-x64.cc:551: return 1; and the same question again (default is present and all cases terminate with returns). http://codereview.chromium.org/8971002/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
