Updated patch: I only left in a patch for the clearly wrong src/debug.cc.
For the others, I concur that the extra return is superfluous as the warning is bogus. Thanks for the careful patch reading. (Actually, I also stumbled over it
yesterday - albeit only after requesting the review.) I have now filled a GCC PR for the bogus warning warning: control reaches end of non-void function [-Wreturn-type] Cf. http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51647 http://codereview.chromium.org/8971002/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
