Feedback addressed, please take another look.
http://codereview.chromium.org/9015020/diff/7001/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): http://codereview.chromium.org/9015020/diff/7001/src/hydrogen-instructions.cc#newcode1 src/hydrogen-instructions.cc:1: // Copyright 2012 the V8 project authors. All rights reserved. On 2012/01/04 09:20:18, fschneider wrote:
There seems to be no other change to this file?
Done. http://codereview.chromium.org/9015020/diff/7001/src/ia32/stub-cache-ia32.cc File src/ia32/stub-cache-ia32.cc (right): http://codereview.chromium.org/9015020/diff/7001/src/ia32/stub-cache-ia32.cc#newcode882 src/ia32/stub-cache-ia32.cc:882: __ CheckMap(reg, current_map, miss, DONT_DO_SMI_CHECK, On 2012/01/04 09:20:18, fschneider wrote:
Is this part of the change missing in stub-cache-arm.cc?
Done. http://codereview.chromium.org/9015020/diff/10001/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): http://codereview.chromium.org/9015020/diff/10001/src/x64/lithium-codegen-x64.cc#newcode3758 src/x64/lithium-codegen-x64.cc:3758: Map* transitioned_double_map = On 2012/01/04 09:20:18, fschneider wrote:
I'd order this differently and move this down closer to the
if-statement where
the result is acutally used.
Done. http://codereview.chromium.org/9015020/diff/10001/src/x64/lithium-codegen-x64.cc#newcode3758 src/x64/lithium-codegen-x64.cc:3758: Map* transitioned_double_map = On 2012/01/04 09:20:18, fschneider wrote:
Handle<Map> transitioned_double_map(...)
Done. http://codereview.chromium.org/9015020/diff/10001/src/x64/lithium-codegen-x64.cc#newcode3762 src/x64/lithium-codegen-x64.cc:3762: Map* transitioned_fast_element_map = On 2012/01/04 09:20:18, fschneider wrote:
Handle<Map> transitioned_fast_element_map(...)
Done. http://codereview.chromium.org/9015020/diff/10001/src/x64/lithium-codegen-x64.cc#newcode3787 src/x64/lithium-codegen-x64.cc:3787: Handle<Map> map = Handle<Map>(instr->hydrogen()->map()); On 2012/01/04 09:20:18, fschneider wrote:
Simpler would be:
Handle<Map> map = instr->hydrogen()->map();
Done. http://codereview.chromium.org/9015020/diff/10001/src/x64/macro-assembler-x64.cc File src/x64/macro-assembler-x64.cc (right): http://codereview.chromium.org/9015020/diff/10001/src/x64/macro-assembler-x64.cc#newcode2753 src/x64/macro-assembler-x64.cc:2753: if (mode == ALLOW_ELEMENT_TRANSITION_MAPS) { On 2012/01/04 09:20:18, fschneider wrote:
The following code is the same as in lithium-codegen, except there is
a branch
at the end instead of the deoptimize. I'd strongly prefer having only
one
version of this code around.
Done. http://codereview.chromium.org/9015020/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
