Please take another look
http://codereview.chromium.org/9015020/diff/14002/src/arm/macro-assembler-arm.cc File src/arm/macro-assembler-arm.cc (right): http://codereview.chromium.org/9015020/diff/14002/src/arm/macro-assembler-arm.cc#newcode2004 src/arm/macro-assembler-arm.cc:2004: Map* transitioned_fast_element_map( On 2012/01/04 12:17:51, fschneider wrote:
Handle<Map>
Done. http://codereview.chromium.org/9015020/diff/14002/src/arm/macro-assembler-arm.cc#newcode2013 src/arm/macro-assembler-arm.cc:2013: Map* transitioned_double_map( On 2012/01/04 12:17:51, fschneider wrote:
Handle<Map>
Done. http://codereview.chromium.org/9015020/diff/14002/src/ia32/macro-assembler-ia32.cc File src/ia32/macro-assembler-ia32.cc (right): http://codereview.chromium.org/9015020/diff/14002/src/ia32/macro-assembler-ia32.cc#newcode497 src/ia32/macro-assembler-ia32.cc:497: Map* transitioned_fast_element_map( On 2012/01/04 12:17:51, fschneider wrote:
If there is no specific reason to use a raw pointer, I'd replace Map*
with
Handle<Map> here.
If code gets moved or copied around, there may be a danger of using
raw pointers
where we must not.
Done. http://codereview.chromium.org/9015020/diff/14002/src/ia32/macro-assembler-ia32.cc#newcode504 src/ia32/macro-assembler-ia32.cc:504: Handle<Map>(transitioned_fast_element_map)); On 2012/01/04 12:17:51, fschneider wrote:
Then there is no need to create a handle here.
Done. http://codereview.chromium.org/9015020/diff/14002/src/ia32/macro-assembler-ia32.cc#newcode507 src/ia32/macro-assembler-ia32.cc:507: Map* transitioned_double_map( On 2012/01/04 12:17:51, fschneider wrote:
Same here.
Done. http://codereview.chromium.org/9015020/diff/14002/src/ia32/macro-assembler-ia32.cc#newcode514 src/ia32/macro-assembler-ia32.cc:514: Handle<Map>(transitioned_double_map)); On 2012/01/04 12:17:51, fschneider wrote:
and here.
Done. http://codereview.chromium.org/9015020/diff/14002/src/x64/macro-assembler-x64.cc File src/x64/macro-assembler-x64.cc (right): http://codereview.chromium.org/9015020/diff/14002/src/x64/macro-assembler-x64.cc#newcode2749 src/x64/macro-assembler-x64.cc:2749: Map* transitioned_fast_element_map( On 2012/01/04 12:17:51, fschneider wrote:
Handle<Map>
Done. http://codereview.chromium.org/9015020/diff/14002/src/x64/macro-assembler-x64.cc#newcode2759 src/x64/macro-assembler-x64.cc:2759: Map* transitioned_double_map( On 2012/01/04 12:17:51, fschneider wrote:
Handle<Map>
Done. http://codereview.chromium.org/9015020/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
