lgtm
http://codereview.chromium.org/9124004/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/9124004/diff/1/src/arm/code-stubs-arm.cc#newcode5398 src/arm/code-stubs-arm.cc:5398: __ and_(hash, hash, Operand(kHashShiftCutOffMask)); Shouldn't it be SetCC? (instead of SetCC on the one above). http://codereview.chromium.org/9124004/diff/1/src/mips/code-stubs-mips.cc File src/mips/code-stubs-mips.cc (right): http://codereview.chromium.org/9124004/diff/1/src/mips/code-stubs-mips.cc#newcode5621 src/mips/code-stubs-mips.cc:5621: // if (hash == 0) hash = 27; should not there be some special masking here? http://codereview.chromium.org/9124004/diff/1/src/objects.h File src/objects.h (right): http://codereview.chromium.org/9124004/diff/1/src/objects.h#newcode6080 src/objects.h:6080: static const uint32_t kHashBitMask = 0xffffffffu >> kHashShift; this constant is duplicated in every code generator. http://codereview.chromium.org/9124004/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
