http://codereview.chromium.org/9124004/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right):
http://codereview.chromium.org/9124004/diff/1/src/arm/code-stubs-arm.cc#newcode5398 src/arm/code-stubs-arm.cc:5398: __ and_(hash, hash, Operand(kHashShiftCutOffMask)); On 2012/01/09 19:09:33, Vyacheslav Egorov wrote:
Shouldn't it be SetCC? (instead of SetCC on the one above).
Good catch, this needs fixing in bleeding edge too. http://codereview.chromium.org/9124004/diff/1/src/mips/code-stubs-mips.cc File src/mips/code-stubs-mips.cc (right): http://codereview.chromium.org/9124004/diff/1/src/mips/code-stubs-mips.cc#newcode5621 src/mips/code-stubs-mips.cc:5621: // if (hash == 0) hash = 27; On 2012/01/09 19:09:33, Vyacheslav Egorov wrote:
should not there be some special masking here?
As noted in the description I wasn't able to get MIPS working correctly, so there may be a followup patch for MIPS (it was already broken in this branch if I understand correctly, the external MIPS git repo is apparently the place to go for 3.6). http://codereview.chromium.org/9124004/diff/1/src/objects.h File src/objects.h (right): http://codereview.chromium.org/9124004/diff/1/src/objects.h#newcode6080 src/objects.h:6080: static const uint32_t kHashBitMask = 0xffffffffu >> kHashShift; On 2012/01/09 19:09:33, Vyacheslav Egorov wrote:
this constant is duplicated in every code generator.
Yes, this should be fixed in bleeding edge. http://codereview.chromium.org/9124004/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
