LGTM with two nits.
http://codereview.chromium.org/9190001/diff/4007/src/ia32/macro-assembler-ia32.cc File src/ia32/macro-assembler-ia32.cc (right): http://codereview.chromium.org/9190001/diff/4007/src/ia32/macro-assembler-ia32.cc#newcode764 src/ia32/macro-assembler-ia32.cc:764: mov(scratch, Immediate(Heap::kHashSeedRootIndex)); There's a missing SmiUntag here. Probably it doesn't matter because there are no number dictionaries in the snapshot, but we should fix it anyway. I will fix it on bleeding edge. http://codereview.chromium.org/9190001/diff/4007/src/ia32/macro-assembler-ia32.cc#newcode766 src/ia32/macro-assembler-ia32.cc:766: times_pointer_size, Somehow the indentation got borked here. http://codereview.chromium.org/9190001/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
