LGTM and committed.
http://codereview.chromium.org/9190001/diff/9001/src/arm/macro-assembler-arm.cc File src/arm/macro-assembler-arm.cc (right): http://codereview.chromium.org/9190001/diff/9001/src/arm/macro-assembler-arm.cc#newcode1362 src/arm/macro-assembler-arm.cc:1362: mul(t0, t0, scratch); This looks like a missing merge, but no big deal. http://codereview.chromium.org/9190001/diff/9001/src/heap.cc File src/heap.cc (right): http://codereview.chromium.org/9190001/diff/9001/src/heap.cc#newcode5365 src/heap.cc:5365: // Setup the seed that is used to randomize the string hash function. AAAAArhg! :-) http://codereview.chromium.org/9190001/diff/9001/src/ia32/code-stubs-ia32.cc File src/ia32/code-stubs-ia32.cc (right): http://codereview.chromium.org/9190001/diff/9001/src/ia32/code-stubs-ia32.cc#newcode5616 src/ia32/code-stubs-ia32.cc:5616: roots_address)); Oops, there's a missing SmiUntag here. I fixed it in 10443 and included the change here before committing. http://codereview.chromium.org/9190001/diff/9001/src/objects.h File src/objects.h (left): http://codereview.chromium.org/9190001/diff/9001/src/objects.h#oldcode1906 src/objects.h:1906: // dictionary. Returns the backing after conversion. Strange removal of this comment, but no big deal. http://codereview.chromium.org/9190001/diff/9001/src/objects.h File src/objects.h (right): http://codereview.chromium.org/9190001/diff/9001/src/objects.h#newcode2537 src/objects.h:2537: // I'm using map()->heap() to skip is_safe_to_read_maps assertion. This comment and the associated change should not be there. http://codereview.chromium.org/9190001/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
