LGMT with one comment to simplify the code slightly.
http://codereview.chromium.org/9207006/diff/1/src/arm/lithium-arm.cc File src/arm/lithium-arm.cc (right): http://codereview.chromium.org/9207006/diff/1/src/arm/lithium-arm.cc#newcode1628 src/arm/lithium-arm.cc:1628: LOperand* value; You can write: LOperand* value = UseRegisterAtStart(instr->value()); here and the code below will be simpler. http://codereview.chromium.org/9207006/diff/1/src/arm/lithium-arm.cc#newcode1635 src/arm/lithium-arm.cc:1635: value = UseRegister(instr->value()); In this case you can also use UseRegisterAtStart. When defining the result with DefineSameAsFirst, UseRegister and UseRegisterAtStart are equivalent for the first input. http://codereview.chromium.org/9207006/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
