Thanks for the review. The updated patch should be uploaded soon.
http://codereview.chromium.org/9207006/diff/1/src/arm/lithium-arm.cc File src/arm/lithium-arm.cc (right): http://codereview.chromium.org/9207006/diff/1/src/arm/lithium-arm.cc#newcode1628 src/arm/lithium-arm.cc:1628: LOperand* value; On 2012/01/16 12:59:20, fschneider wrote:
You can write:
LOperand* value = UseRegisterAtStart(instr->value());
here and the code below will be simpler.
Done. http://codereview.chromium.org/9207006/diff/1/src/arm/lithium-arm.cc#newcode1635 src/arm/lithium-arm.cc:1635: value = UseRegister(instr->value()); On 2012/01/16 12:59:20, fschneider wrote:
In this case you can also use UseRegisterAtStart. When defining the
result with
DefineSameAsFirst, UseRegister and UseRegisterAtStart are equivalent
for the
first input.
Done. http://codereview.chromium.org/9207006/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
