lgtm
http://codereview.chromium.org/9179012/diff/1/src/spaces-inl.h File src/spaces-inl.h (right): http://codereview.chromium.org/9179012/diff/1/src/spaces-inl.h#newcode260 src/spaces-inl.h:260: ASSERT(new_top >= Page::FromAddress(new_top - 1)->ObjectAreaStart()); FromAllocationTop instead of FromAddress http://codereview.chromium.org/9179012/diff/1/src/spaces.cc File src/spaces.cc (right): http://codereview.chromium.org/9179012/diff/1/src/spaces.cc#newcode410 src/spaces.cc:410: // alignment. Code below does not mention map space at all and is generic. http://codereview.chromium.org/9179012/diff/1/src/spaces.cc#newcode419 src/spaces.cc:419: // This will waste the space for one map per doubling of the page size until Code is generic and does not reference map space directly. http://codereview.chromium.org/9179012/diff/1/src/spaces.cc#newcode602 src/spaces.cc:602: Page* MemoryAllocator::AllocatePage(intptr_t object_area_size, object_area_size should really be comitted_object_area_size http://codereview.chromium.org/9179012/diff/1/src/spaces.cc#newcode823 src/spaces.cc:823: reserved_page_size - last_page->size() >= size_in_bytes && I feel uncomfortable when arithmetic expression is not enclosed in parens in comparison. http://codereview.chromium.org/9179012/diff/1/src/spaces.cc#newcode1972 src/spaces.cc:1972: cur = (*cur) == NULL ? cur : (*cur)->next_address()) { *cur == NULL ? NULL : ... for better readability. http://codereview.chromium.org/9179012/diff/1/src/spaces.h File src/spaces.h (right): http://codereview.chromium.org/9179012/diff/1/src/spaces.h#newcode1504 src/spaces.h:1504: virtual int ObjectAlignment() { return kPointerSize; } kObjectAlignment instead of kPointerSize? http://codereview.chromium.org/9179012/diff/1/src/spaces.h#newcode2378 src/spaces.h:2378: virtual int ObjectAlignment() { return object_size_in_bytes_; } for this to be object alignment we have to guarantee that start of object area is appropriately aligned. are we at least asserting that? http://codereview.chromium.org/9179012/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
