On Mon, Jan 16, 2012 at 6:24 PM, Mikhail Naganov <[email protected]> wrote: > Will this change end up in Chrome M18?
It should. We are currently working on V8 version 3.8, which should go into Chrome M18. > On Mon, Jan 16, 2012 at 17:20, <[email protected]> wrote: >> more comments >> >> >> >> http://codereview.chromium.org/9179012/diff/1/src/spaces.cc >> File src/spaces.cc (right): >> >> http://codereview.chromium.org/9179012/diff/1/src/spaces.cc#newcode411 >> src/spaces.cc:411: uintptr_t end_int = old_end - ObjectAreaStart(); >> variable name is wrong. it's size, not end. >> >> http://codereview.chromium.org/9179012/diff/1/src/spaces.cc#newcode412 >> src/spaces.cc:412: uintptr_t aligned_end_int = >> ditto >> >> http://codereview.chromium.org/9179012/diff/1/src/spaces.cc#newcode414 >> src/spaces.cc:414: if (aligned_end_int < end_int) { >> != instead of < for readability >> >> http://codereview.chromium.org/9179012/ >> >> >> -- >> v8-dev mailing list >> [email protected] >> http://groups.google.com/group/v8-dev -- Erik Corry, Software Engineer Google Denmark ApS - Frederiksborggade 20B, 1 sal, 1360 København K - Denmark - CVR nr. 28 86 69 84 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
