LGTM
https://chromiumcodereview.appspot.com/9290013/diff/1/src/debug.cc File src/debug.cc (right): https://chromiumcodereview.appspot.com/9290013/diff/1/src/debug.cc#newcode1783 src/debug.cc:1783: Object* active_code_marker = isolate_->heap()->the_hole_value(); It seems we only go through the stack for the current thread, leaving the other threads to crash, but lets fix that in a different change. https://chromiumcodereview.appspot.com/9290013/diff/1/src/debug.cc#newcode1807 src/debug.cc:1807: // Scan the heap for all non-optimized functions which has no has -> have https://chromiumcodereview.appspot.com/9290013/diff/1/test/mjsunit/regress/regress-debug-code-recompilation.js File test/mjsunit/regress/regress-debug-code-recompilation.js (right): https://chromiumcodereview.appspot.com/9290013/diff/1/test/mjsunit/regress/regress-debug-code-recompilation.js#newcode36 test/mjsunit/regress/regress-debug-code-recompilation.js:36: } The test does not seem to test having anything on the stack when breakpoints are activated. https://chromiumcodereview.appspot.com/9290013/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
