LGTM

https://chromiumcodereview.appspot.com/9290013/diff/1007/src/debug.cc
File src/debug.cc (right):

https://chromiumcodereview.appspot.com/9290013/diff/1007/src/debug.cc#newcode1843
src/debug.cc:1843: frame_code->instruction_size(),
Can we indent lines like this so that we have only the start of a new
argument to PrintF at this indentation level?

https://chromiumcodereview.appspot.com/9290013/diff/1007/src/debug.cc#newcode1904
src/debug.cc:1904: Object* active_code_marker =
isolate_->heap()->the_hole_value();
I know the hole never moves or dies, but it seems a bit gratuitous to do
this before the call the CollectAllGarbage.

https://chromiumcodereview.appspot.com/9290013/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to