https://chromiumcodereview.appspot.com/9235029/diff/1/src/heap.cc File src/heap.cc (right):
https://chromiumcodereview.appspot.com/9235029/diff/1/src/heap.cc#newcode899 src/heap.cc:899: FlushNumberStringCache(); On 2012/01/25 13:00:56, Michael Starzinger wrote:
If it's intentional that the new heuristic for flushing is "always
flush", then
I am fine with that. Please document that in the issue tracker.
Done. https://chromiumcodereview.appspot.com/9235029/diff/1/src/heap.cc#newcode2630 src/heap.cc:2630: // max_semispace_size_ == 512 KB => number_string_cache_size = 32. On 2012/01/25 13:00:56, Michael Starzinger wrote:
This comment no longer is on sync with the computation below.
Done. https://chromiumcodereview.appspot.com/9235029/diff/1/src/heap.cc#newcode2633 src/heap.cc:2633: number_string_cache_size = Max(kInitialNumberStringCacheSize * 2, On 2012/01/25 13:00:56, Michael Starzinger wrote:
The constant is multiplied with 2 twice. I think we can drop this multiplication.
The first multiplication is there to ensure that the full size is always bigger than the initial size. The second is there because there is a string and a number per entry so the length has to be twice the size (in entries). Comments have been updated. https://chromiumcodereview.appspot.com/9235029/diff/1/src/heap.cc#newcode2647 src/heap.cc:2647: if (maybe_obj->ToObject(&new_cache)) { On 2012/01/25 13:00:56, Michael Starzinger wrote:
Can we add a comment that this is a best effort allocation and we
ignore
failures here?
Done. https://chromiumcodereview.appspot.com/9235029/diff/1/src/heap.h File src/heap.h (right): https://chromiumcodereview.appspot.com/9235029/diff/1/src/heap.h#newcode1804 src/heap.h:1804: // Initializes the number to string cache based on the max semispace size. On 2012/01/25 13:00:56, Michael Starzinger wrote:
This comment line should either be moved up two lines or be dropped
completely. Done. https://chromiumcodereview.appspot.com/9235029/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
