Please take another look.
On 2012/01/27 13:19:11, ulan wrote:
LGTM if comments are addressed.
http://codereview.chromium.org/9223011/diff/1/src/arm/builtins-arm.cc
File src/arm/builtins-arm.cc (right):
http://codereview.chromium.org/9223011/diff/1/src/arm/builtins-arm.cc#newcode157
src/arm/builtins-arm.cc:157: __ LoadRoot(scratch3,
Heap::kFixedArrayMapRootIndex);
In this case it seems to reduce readability. I think such optimizations
should
be done on hot paths only.
http://codereview.chromium.org/9223011/diff/1/src/arm/builtins-arm.cc#newcode258
src/arm/builtins-arm.cc:258: __ LoadRoot(scratch1,
Heap::kFixedArrayMapRootIndex);
Ditto.
http://codereview.chromium.org/9223011/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):
http://codereview.chromium.org/9223011/diff/1/src/arm/code-stubs-arm.cc#newcode587
src/arm/code-stubs-arm.cc:587: STATIC_ASSERT(kSmiTagSize == 1 && kSmiTag
==
0);
Can we introduce UntagAndJumpIfSmi for these tree lines?
http://codereview.chromium.org/9223011/diff/1/src/arm/code-stubs-arm.cc#newcode650
src/arm/code-stubs-arm.cc:650: STATIC_ASSERT(kSmiTagSize == 1 && kSmiTag
==
0);
UntagAndJumpIfSmi
http://codereview.chromium.org/9223011/diff/1/src/arm/code-stubs-arm.cc#newcode846
src/arm/code-stubs-arm.cc:846: // If the object is a smi, return it in
destination register, untagged.
UntagAndJumpIfSmi
http://codereview.chromium.org/9223011/diff/1/src/arm/code-stubs-arm.cc#newcode3477
src/arm/code-stubs-arm.cc:3477: __ mov(scratch, Operand(base, ASR,
kSmiTagSize),
SetCC);
UntagAndJumpIfSmi
http://codereview.chromium.org/9223011/diff/1/src/arm/code-stubs-arm.cc#newcode3493
src/arm/code-stubs-arm.cc:3493: __ mov(scratch, Operand(exponent, ASR,
kSmiTagSize), SetCC);
UntagAndJumpIfSmi
http://codereview.chromium.org/9223011/diff/1/src/arm/code-stubs-arm.cc#newcode3503
src/arm/code-stubs-arm.cc:3503: __ mov(scratch, Operand(exponent, ASR,
kSmiTagSize), SetCC);
UntagAndJumpIfSmi
http://codereview.chromium.org/9223011/diff/1/src/arm/codegen-arm.cc
File src/arm/codegen-arm.cc (right):
http://codereview.chromium.org/9223011/diff/1/src/arm/codegen-arm.cc#newcode158
src/arm/codegen-arm.cc:158: STATIC_ASSERT(kSmiTagSize == 1 && kSmiTag ==
0);
Can we introduce UntagAndJumpIfNotSmi for these tree lines?
http://codereview.chromium.org/9223011/diff/1/src/arm/codegen-arm.cc#newcode344
src/arm/codegen-arm.cc:344: __ b(ne, call_runtime); // This branch
refers to
the previous CompareRoot.
This branch should be above the comment in line 343.
http://codereview.chromium.org/9223011/diff/1/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):
http://codereview.chromium.org/9223011/diff/1/src/arm/lithium-codegen-arm.cc#newcode3931
src/arm/lithium-codegen-arm.cc:3931: STATIC_CHECK(kSmiTagSize == 1 &&
kSmiTag
==
0);
UntagAndJumpIfSmi
http://codereview.chromium.org/9223011/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
