LGTM with nits.
http://codereview.chromium.org/9223011/diff/1008/src/arm/macro-assembler-arm.cc File src/arm/macro-assembler-arm.cc (right): http://codereview.chromium.org/9223011/diff/1008/src/arm/macro-assembler-arm.cc#newcode2977 src/arm/macro-assembler-arm.cc:2977: Register dst, Register src, Label* smi_case) { smi_case should be non_smi_case http://codereview.chromium.org/9223011/diff/1008/src/arm/macro-assembler-arm.h File src/arm/macro-assembler-arm.h (right): http://codereview.chromium.org/9223011/diff/1008/src/arm/macro-assembler-arm.h#newcode1152 src/arm/macro-assembler-arm.h:1152: // Tentatively untag and jump if the value has been a smi. "Tentatively" is a bit misleading, since the function doesn't restore the original values. Consider something along this lines: Untag the source register to the destination register and jump if the source register is a smi. The source and the destination registers can be the same. http://codereview.chromium.org/9223011/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
