LGTM with nits.
http://codereview.chromium.org/9298012/diff/7002/tools/merge-to-branch.sh File tools/merge-to-branch.sh (right): http://codereview.chromium.org/9298012/diff/7002/tools/merge-to-branch.sh#newcode206 tools/merge-to-branch.sh:206: NEW_COMMIT_MSG="Merged$NEW_COMMIT_MSG into \ nit: fits on one line http://codereview.chromium.org/9298012/diff/7002/tools/merge-to-branch.sh#newcode211 tools/merge-to-branch.sh:211: for HASH in ${PATCH_COMMIT_HASHES[@]} ; do nit: double space before "do" http://codereview.chromium.org/9298012/diff/7002/tools/merge-to-branch.sh#newcode228 tools/merge-to-branch.sh:228: echo "BUG=none" >> $COMMITMSG_FILE I'd just remove this. "BUG=none" adds no useful information. http://codereview.chromium.org/9298012/diff/7002/tools/merge-to-branch.sh#newcode230 tools/merge-to-branch.sh:230: echo -n "TEST=none" >> $COMMITMSG_FILE Same here. http://codereview.chromium.org/9298012/diff/7002/tools/merge-to-branch.sh#newcode251 tools/merge-to-branch.sh:251: MAJOR=$(grep "#define MAJOR_VERSION" "$VERSION_FILE" | awk '{print $NF}') AFAICS the tag is created using NEWMAJOR, NEWMINOR, NEWBUILD, which are created and persisted in the next step. So you really don't need these. http://codereview.chromium.org/9298012/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
