Feedback addressed, landing
https://chromiumcodereview.appspot.com/9298012/diff/7002/tools/merge-to-branch.sh File tools/merge-to-branch.sh (right): https://chromiumcodereview.appspot.com/9298012/diff/7002/tools/merge-to-branch.sh#newcode206 tools/merge-to-branch.sh:206: NEW_COMMIT_MSG="Merged$NEW_COMMIT_MSG into \ On 2012/01/31 11:11:10, Jakob wrote:
nit: fits on one line
Done. https://chromiumcodereview.appspot.com/9298012/diff/7002/tools/merge-to-branch.sh#newcode211 tools/merge-to-branch.sh:211: for HASH in ${PATCH_COMMIT_HASHES[@]} ; do On 2012/01/31 11:11:10, Jakob wrote:
nit: double space before "do"
Done. https://chromiumcodereview.appspot.com/9298012/diff/7002/tools/merge-to-branch.sh#newcode228 tools/merge-to-branch.sh:228: echo "BUG=none" >> $COMMITMSG_FILE On 2012/01/31 11:11:10, Jakob wrote:
I'd just remove this. "BUG=none" adds no useful information.
Done. https://chromiumcodereview.appspot.com/9298012/diff/7002/tools/merge-to-branch.sh#newcode230 tools/merge-to-branch.sh:230: echo -n "TEST=none" >> $COMMITMSG_FILE On 2012/01/31 11:11:10, Jakob wrote:
Same here.
Done. https://chromiumcodereview.appspot.com/9298012/diff/7002/tools/merge-to-branch.sh#newcode251 tools/merge-to-branch.sh:251: MAJOR=$(grep "#define MAJOR_VERSION" "$VERSION_FILE" | awk '{print $NF}') On 2012/01/31 11:11:10, Jakob wrote:
AFAICS the tag is created using NEWMAJOR, NEWMINOR, NEWBUILD, which
are created
and persisted in the next step. So you really don't need these.
Done. https://chromiumcodereview.appspot.com/9298012/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
