I've only taken a cursory glance, and all I've found are three nits :-)
http://codereview.chromium.org/9310117/diff/13029/src/code-stubs.h File src/code-stubs.h (right): http://codereview.chromium.org/9310117/diff/13029/src/code-stubs.h#newcode990 src/code-stubs.h:990: : is_js_array_(is_js_array), nit: 4-space indent http://codereview.chromium.org/9310117/diff/13029/src/objects-debug.cc File src/objects-debug.cc (right): http://codereview.chromium.org/9310117/diff/13029/src/objects-debug.cc#newcode284 src/objects-debug.cc:284: || map()->has_fast_smi_only_elements() || nit: all operators at the end of the line, please. http://codereview.chromium.org/9310117/diff/13029/src/stub-cache.h File src/stub-cache.h (right): http://codereview.chromium.org/9310117/diff/13029/src/stub-cache.h#newcode707 src/stub-cache.h:707: PropertyType type, Why this formatting change? http://codereview.chromium.org/9310117/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
