Initial round of comments
http://codereview.chromium.org/9310117/diff/13029/src/arm/codegen-arm.cc File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/9310117/diff/13029/src/arm/codegen-arm.cc#newcode126 src/arm/codegen-arm.cc:126: EMIT_REMEMBERED_SET, OMIT_REMEMBERED_SET (maps are never in new space). http://codereview.chromium.org/9310117/diff/13029/src/arm/codegen-arm.cc#newcode163 src/arm/codegen-arm.cc:163: EMIT_REMEMBERED_SET, OMIT_REMEMBERED_SET (maps are never in new space). http://codereview.chromium.org/9310117/diff/13029/src/arm/codegen-arm.cc#newcode329 src/arm/codegen-arm.cc:329: EMIT_REMEMBERED_SET, OMIT_ http://codereview.chromium.org/9310117/diff/13029/src/ia32/codegen-ia32.cc File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/9310117/diff/13029/src/ia32/codegen-ia32.cc#newcode422 src/ia32/codegen-ia32.cc:422: EMIT_REMEMBERED_SET, map can not be in new space. We only need an incremental write barrier here. http://codereview.chromium.org/9310117/diff/13029/src/ia32/codegen-ia32.cc#newcode474 src/ia32/codegen-ia32.cc:474: EMIT_REMEMBERED_SET, ditto http://codereview.chromium.org/9310117/diff/13029/src/ia32/stub-cache-ia32.cc File src/ia32/stub-cache-ia32.cc (right): http://codereview.chromium.org/9310117/diff/13029/src/ia32/stub-cache-ia32.cc#newcode3776 src/ia32/stub-cache-ia32.cc:3776: if (is_js_array && grow_mode == ALLOW_JSARRAY_GROWTH) { We might have setters on the prototype: function add(x) { x[x.length] = x.length; } Array.prototype.__defineSetter__("1", function (v) { print("I am setter!"); }); var x = new Array(0); add(x); add(x); I think this setter will fire without this CL (which is correct) but will not fire with this CL. This seems like yet another "setter on the prototype" compat problem. http://codereview.chromium.org/9310117/diff/13029/src/ia32/stub-cache-ia32.cc#newcode3823 src/ia32/stub-cache-ia32.cc:3823: __ add(FieldOperand(edx, JSArray::kLengthOffset), can be actually move of smi 1 instead of addition as length is known to be 0. http://codereview.chromium.org/9310117/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
