The issue description should describe all independent changes:

1. Enable smi-only arrays.

2. Enable GVN of TransitionElementsKind in the case where...



https://chromiumcodereview.appspot.com/9365057/diff/2001/src/hydrogen.cc
File src/hydrogen.cc (right):

https://chromiumcodereview.appspot.com/9365057/diff/2001/src/hydrogen.cc#newcode1196
src/hydrogen.cc:1196: !value->IsTransitionElementsKind()) {  // Drop it.
I don't understand why skipping transition instructions here is this
necessary (and correct).
The dependency flags should be enough to control GVN for the
HTransitionElementsKind.

https://chromiumcodereview.appspot.com/9365057/diff/2001/test/mjsunit/elements-transition-hoisting.js
File test/mjsunit/elements-transition-hoisting.js (right):

https://chromiumcodereview.appspot.com/9365057/diff/2001/test/mjsunit/elements-transition-hoisting.js#newcode186
test/mjsunit/elements-transition-hoisting.js:186: print("DUDE");
Printing can be removed.

https://chromiumcodereview.appspot.com/9365057/diff/2001/test/mjsunit/elements-transition-hoisting.js#newcode197
test/mjsunit/elements-transition-hoisting.js:197: print("DUDE2");
Printing can be removed.

https://chromiumcodereview.appspot.com/9365057/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to