Whoops. Wrong version uploaded. I uploaded the right one with your feedback addressed.
The smi-only flag shouldn't be set at all yet, that was a mistake. http://codereview.chromium.org/9365057/diff/2001/src/hydrogen.cc File src/hydrogen.cc (right): http://codereview.chromium.org/9365057/diff/2001/src/hydrogen.cc#newcode1196 src/hydrogen.cc:1196: !value->IsTransitionElementsKind()) { // Drop it. On 2012/02/15 15:36:48, fschneider wrote:
I don't understand why skipping transition instructions here is this
necessary
(and correct). The dependency flags should be enough to control GVN for the HTransitionElementsKind.
Done. http://codereview.chromium.org/9365057/diff/2001/test/mjsunit/elements-transition-hoisting.js File test/mjsunit/elements-transition-hoisting.js (right): http://codereview.chromium.org/9365057/diff/2001/test/mjsunit/elements-transition-hoisting.js#newcode186 test/mjsunit/elements-transition-hoisting.js:186: print("DUDE"); On 2012/02/15 15:36:48, fschneider wrote:
Printing can be removed.
Done. http://codereview.chromium.org/9365057/diff/2001/test/mjsunit/elements-transition-hoisting.js#newcode197 test/mjsunit/elements-transition-hoisting.js:197: print("DUDE2"); On 2012/02/15 15:36:48, fschneider wrote:
Printing can be removed.
Done. http://codereview.chromium.org/9365057/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
