https://chromiumcodereview.appspot.com/9425045/diff/1/src/handles.cc File src/handles.cc (right):
https://chromiumcodereview.appspot.com/9425045/diff/1/src/handles.cc#newcode750 src/handles.cc:750: if (!indexes.is_null()) { s/indexes/indices/g https://chromiumcodereview.appspot.com/9425045/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://chromiumcodereview.appspot.com/9425045/diff/1/src/hydrogen.cc#newcode3259 src/hydrogen.cc:3259: HInstruction* start_index = AddInstruction(new(zone()) HConstant( You could use PushAndAdd here in these cases. https://chromiumcodereview.appspot.com/9425045/diff/1/src/hydrogen.cc#newcode3261 src/hydrogen.cc:3261: Remove \n. https://chromiumcodereview.appspot.com/9425045/diff/1/src/hydrogen.cc#newcode3319 src/hydrogen.cc:3319: HValue* next_index = AddInstruction( You could use PushAndAdd here. https://chromiumcodereview.appspot.com/9425045/diff/1/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): https://chromiumcodereview.appspot.com/9425045/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode4798 src/ia32/lithium-codegen-ia32.cc:4798: JSObject::kHeaderSize - kHeapObjectTag)); Maybe use FieldOperand instead to avoid having to subtract the kHeapObjectTag. https://chromiumcodereview.appspot.com/9425045/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode4807 src/ia32/lithium-codegen-ia32.cc:4807: kPointerSize - kHeapObjectTag)); Shouldn't this be FixedArray::kHeaderSize - kHeapObjectTag? https://chromiumcodereview.appspot.com/9425045/diff/1/src/ia32/lithium-ia32.cc File src/ia32/lithium-ia32.cc (right): https://chromiumcodereview.appspot.com/9425045/diff/1/src/ia32/lithium-ia32.cc#newcode2430 src/ia32/lithium-ia32.cc:2430: return AssignEnvironment(DefineAsRegister(new(zone()) LCheckMapValue(value, map))); Long line. https://chromiumcodereview.appspot.com/9425045/diff/1/src/ia32/lithium-ia32.cc#newcode2430 src/ia32/lithium-ia32.cc:2430: return AssignEnvironment(DefineAsRegister(new(zone()) LCheckMapValue(value, map))); Since the result of the HCheckMapValue instruction is not used, you don't need to assign an output register here. https://chromiumcodereview.appspot.com/9425045/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
