I think the CL is almost there. A few more comments:
http://codereview.chromium.org/9455088/diff/21035/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/9455088/diff/21035/src/arm/code-stubs-arm.cc#newcode4135 src/arm/code-stubs-arm.cc:4135: map = Register::from_code(kRegisterNoneCode); Why do you need to replace no_reg here? http://codereview.chromium.org/9455088/diff/21035/src/arm/code-stubs-arm.cc#newcode4886 src/arm/code-stubs-arm.cc:4886: __ LeaveExitFrame(false, Register::from_code(kRegisterNoneCode)); Why do you need to replace no_reg here? http://codereview.chromium.org/9455088/diff/21035/src/ia32/code-stubs-ia32.cc File src/ia32/code-stubs-ia32.cc (right): http://codereview.chromium.org/9455088/diff/21035/src/ia32/code-stubs-ia32.cc#newcode7036 src/ia32/code-stubs-ia32.cc:7036: #define REG(Name) { kRegister ## Name ## Code } Yes, I'd rather prefer kRegister_eax_Code in this case, so that the names used here match the rest of the register names. http://codereview.chromium.org/9455088/diff/21035/src/isolate.cc File src/isolate.cc (right): http://codereview.chromium.org/9455088/diff/21035/src/isolate.cc#newcode410 src/isolate.cc:410: return global_state.Pointer()->default_isolate->stack_guard(); Here you use Pointer() and further down Get(). It would be nice to be consistent. i.e. use Pointer() only if a pointer is actually needed, otherwise Get(). http://codereview.chromium.org/9455088/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
