Yes, this is what used to spot them. Unfortunately it seems that we can't easily get rid of at least one of them (in x86 atomicops) so we can't use both -Wglobal-constructors and -Werror for now. It is definitely the way to go if we can reach 0 static initializers. Meanwhile we can rely on the Shell script being integrated by Michael in the build bots scripts: http://chromiumcodereview.appspot.com/9663071/
On Tue, Mar 13, 2012 at 11:31 AM, Dmitriy Vyukov <[email protected]>wrote: > Just in case, clang can detect global constructors, so if you build code > base with CXX="clang++ -Wglobal-constructors", it should warn you about all > such cases. For some of our projects we added -Wglobal-constructors into > Makefiles, so that no new instances are added. > > > > On Mon, Mar 12, 2012 at 3:52 PM, Philippe Liard <[email protected]> wrote: > >> Thanks Florian! >> >> >> On Mon, Mar 12, 2012 at 11:50 AM, <[email protected]> wrote: >> >>> On 2012/03/12 11:48:01, fschneider wrote: >>> >>>> lgtm >>>> >>> >>> I'll land this together with >>> http://codereview.chromium.**org/9447052/<http://codereview.chromium.org/9447052/>since >>> those >>> two really belong together. >>> >>> http://codereview.chromium.**org/9455088/<http://codereview.chromium.org/9455088/> >>> >> >> > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
