Reviewers: Sven Panne, Jakob,
Message:
PTAL.
Sven, can you take a look at the template usage. Jakob, please take a look
at
the element accessor changes.
Review guidance:
- Start in elements.h. There are new virtual methods on ElementsAccessor
for
copying elements from on elements backing store to another.
- In elements.cc, a Traits class has been used that maps an ElementsKind to
its
backing store are compile time. The changes in the macros allow the traits
classes to be generated automatically. The bulk of the changes are the
implementation of CopyElementsImpl in the elements specialization classes,
which
call specialized copiers.
- builtins.cc new uses the common object-to-object copying method that is
also
used by the ElementAccessor
Description:
Implement efficient element copying in ElementsAccessors.
Please review this at https://chromiumcodereview.appspot.com/9638014/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/builtins.cc
M src/elements.h
M src/elements.cc
M src/objects.cc
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
