Revision: 10970
Author: [email protected]
Date: Thu Mar 8 10:27:39 2012
Log: Fix signed / unsigned warnings for ?: operators reported by Xcode
4.x clang compiler.
The patch is based on the report provided by github user Zakay.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9592030
http://code.google.com/p/v8/source/detail?r=10970
Modified:
/branches/bleeding_edge/src/api.cc
/branches/bleeding_edge/src/hydrogen-instructions.cc
=======================================
--- /branches/bleeding_edge/src/api.cc Wed Mar 7 09:38:50 2012
+++ /branches/bleeding_edge/src/api.cc Thu Mar 8 10:27:39 2012
@@ -525,7 +525,8 @@
int source_length)
: name_(name),
source_length_(source_length >= 0 ?
- source_length : (source ? strlen(source) : 0)),
+ source_length :
+ (source ? static_cast<int>(strlen(source)) : 0)),
source_(source, source_length_),
dep_count_(dep_count),
deps_(deps),
=======================================
--- /branches/bleeding_edge/src/hydrogen-instructions.cc Fri Mar 2
05:40:14 2012
+++ /branches/bleeding_edge/src/hydrogen-instructions.cc Thu Mar 8
10:27:39 2012
@@ -1348,12 +1348,13 @@
Range* HBitwise::InferRange(Zone* zone) {
if (op() == Token::BIT_XOR) return HValue::InferRange(zone);
+ const int32_t kDefaultMask = static_cast<int32_t>(0xffffffff);
int32_t left_mask = (left()->range() != NULL)
? left()->range()->Mask()
- : 0xffffffff;
+ : kDefaultMask;
int32_t right_mask = (right()->range() != NULL)
? right()->range()->Mask()
- : 0xffffffff;
+ : kDefaultMask;
int32_t result_mask = (op() == Token::BIT_AND)
? left_mask & right_mask
: left_mask | right_mask;
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
