almost there. please fix last comments.
http://codereview.chromium.org/9634005/diff/7002/src/spaces.cc File src/spaces.cc (right): http://codereview.chromium.org/9634005/diff/7002/src/spaces.cc#newcode2591 src/spaces.cc:2591: uint32_t base = reinterpret_cast<uint32_t>(page)/MemoryChunk::kAlignment; casting page to uint32_t is not suitable for 64-bit arch. consider using uintptr_t instead. http://codereview.chromium.org/9634005/diff/7002/src/spaces.cc#newcode2616 src/spaces.cc:2616: LargePage* page = FindPageContainingPc(a); I would suggest retaining FindPageContainingPc because you are calling it from the function that is used for arbitrary addresses. http://codereview.chromium.org/9634005/diff/7002/src/spaces.cc#newcode2633 src/spaces.cc:2633: if (page_address <= pc && pc < page_address + page->size()) { Consider using page->Contains(pc) here. http://codereview.chromium.org/9634005/diff/7002/src/spaces.cc#newcode2673 src/spaces.cc:2673: uint32_t base = reinterpret_cast<uint32_t>(page)/MemoryChunk::kAlignment; casting page to uint32_t is not suitable for 64-bit arch. consider using uintptr_t instead. http://codereview.chromium.org/9634005/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
