We are almost there I think.
http://codereview.chromium.org/9634005/diff/7002/src/spaces.cc File src/spaces.cc (right): http://codereview.chromium.org/9634005/diff/7002/src/spaces.cc#newcode2616 src/spaces.cc:2616: LargePage* page = FindPageContainingPc(a); On 2012/03/13 01:44:35, kewpie.w.zp wrote:
On 2012/03/12 12:04:12, Vyacheslav Egorov wrote: > On 2012/03/12 02:00:40, kewpie.w.zp wrote: > > On 2012/03/09 12:15:37, Vyacheslav Egorov wrote: > > > I would suggest retaining FindPageContainingPc because you are
calling it
> from > > > the function that is used for arbitrary addresses. > > > > Not very sure if I catch your point. Please allow me to confirm.
Do you
> suggest > > retaining the linear search of FindPageContainingPc() and just
change
> > FindObject() to hash lookup, or reversed, or something else ?
Thanks a lot
for > > your answering > > My original comment should read: "I would suggest _renaming_...".
Sorry for
the > confusion, there was a typo. > > My point was that there is nothing PC or code object specific in the
code.
I see. Maybe it's named so because called by InnerPointerToCodeCache::GcSafeFindCodeForInnerPointer(). How about
change to
"FindPage(Address a)", or something else you'd like to recommend ?
FindPage sounds good to me http://codereview.chromium.org/9634005/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
