LGTM (with one bug). I just looked at the write-barrier related stuff.
https://chromiumcodereview.appspot.com/9638014/diff/9003/src/elements.cc File src/elements.cc (right): https://chromiumcodereview.appspot.com/9638014/diff/9003/src/elements.cc#newcode222 src/elements.cc:222: if (!maybe_value->ToObject(&value)) { If you are sure that this can only fail because of an allocation failure, I would add an assertion like the following here. ASSERT(maybe_value->IsRetryAfterGC() || maybe_value->IsOutOfMemory()); https://chromiumcodereview.appspot.com/9638014/diff/9003/src/elements.cc#newcode225 src/elements.cc:225: heap->AllocateHeapNumber(from_obj->get_scalar(i), TENURED); Shouldn't this be "get_scalar(i + from_start)" here? https://chromiumcodereview.appspot.com/9638014/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
