Feedback addressed, landing
http://codereview.chromium.org/9638014/diff/9003/src/elements.cc File src/elements.cc (right): http://codereview.chromium.org/9638014/diff/9003/src/elements.cc#newcode222 src/elements.cc:222: if (!maybe_value->ToObject(&value)) { On 2012/03/09 12:34:32, Michael Starzinger wrote:
If you are sure that this can only fail because of an allocation
failure, I
would add an assertion like the following here.
ASSERT(maybe_value->IsRetryAfterGC() || maybe_value->IsOutOfMemory());
Done. http://codereview.chromium.org/9638014/diff/9003/src/elements.cc#newcode225 src/elements.cc:225: heap->AllocateHeapNumber(from_obj->get_scalar(i), TENURED); On 2012/03/09 12:34:32, Michael Starzinger wrote:
Shouldn't this be "get_scalar(i + from_start)" here?
Done. http://codereview.chromium.org/9638014/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
