I would suggest changing description. This is not promotion heuristic. Vyacheslav Egorov On Mar 9, 2012 11:04 PM, <[email protected]> wrote:
> Reviewers: Michael Starzinger, > > Message: > PTAL. > > Description: > Tweak promotion heuristics to avoid excessive mark and sweep. > > > BUG= > TEST= > > > Please review this at > http://codereview.chromium.**org/9674001/<http://codereview.chromium.org/9674001/> > > SVN Base: > https://v8.googlecode.com/svn/**branches/bleeding_edge<https://v8.googlecode.com/svn/branches/bleeding_edge> > > Affected files: > M src/incremental-marking.cc > > > Index: src/incremental-marking.cc > diff --git a/src/incremental-marking.cc b/src/incremental-marking.cc > index d0346171d3db3f164831d64c56d9d2**9e848753c8..** > c4f166bb9877f0fad7a27843e2f5d9**5636d75033 100644 > --- a/src/incremental-marking.cc > +++ b/src/incremental-marking.cc > @@ -396,7 +396,7 @@ bool IncrementalMarking::**WorthActivating() { > return !FLAG_expose_gc && > FLAG_incremental_marking && > !Serializer::enabled() && > - heap_->PromotedSpaceSize() > kActivationThreshold; > + heap_->**PromotedSpaceSizeOfObjects() > kActivationThreshold; > } > > > > > -- > v8-dev mailing list > [email protected] > http://groups.google.com/**group/v8-dev<http://groups.google.com/group/v8-dev> > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
