The description is still not quite right. It doesn't avoid excessive marking it avoids starting incremental marking for no apparent reason. How about the following description:
=== Fix heuristic triggering incremental marking. This changes the heuristic that starts incremental marking to be based on a more accurate heap size estimation. Pages being swept lazily can be accounted using the live bytes counter. [email protected] BUG=v8:1682 === Best regards, Michael On Sat, Mar 10, 2012 at 01:12, Yang Guo <[email protected]> wrote: > I changed the description. Michael is the one who suggested this change > which solves a problem with mark and sweep collections that seem to happen > for no reason. > > Yang > > > On Sat, Mar 10, 2012 at 12:21 AM, Vyacheslav Egorov <[email protected]>wrote: > >> I would suggest changing description. This is not promotion heuristic. >> >> Vyacheslav Egorov >> On Mar 9, 2012 11:04 PM, <[email protected]> wrote: >> >>> Reviewers: Michael Starzinger, >>> >>> Message: >>> PTAL. >>> >>> Description: >>> Tweak promotion heuristics to avoid excessive mark and sweep. >>> >>> >>> BUG= >>> TEST= >>> >>> >>> Please review this at >>> http://codereview.chromium.**org/9674001/<http://codereview.chromium.org/9674001/> >>> >>> SVN Base: >>> https://v8.googlecode.com/svn/**branches/bleeding_edge<https://v8.googlecode.com/svn/branches/bleeding_edge> >>> >>> Affected files: >>> M src/incremental-marking.cc >>> >>> >>> Index: src/incremental-marking.cc >>> diff --git a/src/incremental-marking.cc b/src/incremental-marking.cc >>> index d0346171d3db3f164831d64c56d9d2**9e848753c8..** >>> c4f166bb9877f0fad7a27843e2f5d9**5636d75033 100644 >>> --- a/src/incremental-marking.cc >>> +++ b/src/incremental-marking.cc >>> @@ -396,7 +396,7 @@ bool IncrementalMarking::**WorthActivating() { >>> return !FLAG_expose_gc && >>> FLAG_incremental_marking && >>> !Serializer::enabled() && >>> - heap_->PromotedSpaceSize() > kActivationThreshold; >>> + heap_->**PromotedSpaceSizeOfObjects() > kActivationThreshold; >>> } >>> >>> >>> >>> >>> -- >>> v8-dev mailing list >>> [email protected] >>> http://groups.google.com/**group/v8-dev<http://groups.google.com/group/v8-dev> >>> >> -- >> v8-dev mailing list >> [email protected] >> http://groups.google.com/group/v8-dev > > > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
