Almost....
https://chromiumcodereview.appspot.com/9950095/diff/1/src/runtime.cc File src/runtime.cc (right): https://chromiumcodereview.appspot.com/9950095/diff/1/src/runtime.cc#newcode4684 src/runtime.cc:4684: ASSERT(elements_kind == boilerplate->GetElementsKind()); The boilerplate could also be FAST_ELEMENTS at this point. You need to make sure that the boilerplate has transitioned to at least the ElementsKind that's needed, but beyond is OK, too. You might want to use IsMoreGeneralElementsKindTransition for this test. https://chromiumcodereview.appspot.com/9950095/diff/1/src/runtime.cc#newcode4698 src/runtime.cc:4698: } Same here. https://chromiumcodereview.appspot.com/9950095/diff/1/test/mjsunit/regress/regress-2055.js File test/mjsunit/regress/regress-2055.js (right): https://chromiumcodereview.appspot.com/9950095/diff/1/test/mjsunit/regress/regress-2055.js#newcode39 test/mjsunit/regress/regress-2055.js:39: assertEquals([0,[0,[]]], foo(2)); Test the crazy case that I describe in the .cc file. https://chromiumcodereview.appspot.com/9950095/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
