Added new patch set. PTAL.
https://chromiumcodereview.appspot.com/9950095/diff/1/src/runtime.cc File src/runtime.cc (right): https://chromiumcodereview.appspot.com/9950095/diff/1/src/runtime.cc#newcode4684 src/runtime.cc:4684: ASSERT(elements_kind == boilerplate->GetElementsKind()); On 2012/04/03 15:47:46, danno wrote:
The boilerplate could also be FAST_ELEMENTS at this point. You need to
make sure
that the boilerplate has transitioned to at least the ElementsKind
that's
needed, but beyond is OK, too. You might want to use IsMoreGeneralElementsKindTransition for this test.
Done. https://chromiumcodereview.appspot.com/9950095/diff/1/src/runtime.cc#newcode4698 src/runtime.cc:4698: } On 2012/04/03 15:47:46, danno wrote:
Same here.
Done. https://chromiumcodereview.appspot.com/9950095/diff/1/test/mjsunit/regress/regress-2055.js File test/mjsunit/regress/regress-2055.js (right): https://chromiumcodereview.appspot.com/9950095/diff/1/test/mjsunit/regress/regress-2055.js#newcode39 test/mjsunit/regress/regress-2055.js:39: assertEquals([0,[0,[]]], foo(2)); On 2012/04/03 15:47:46, danno wrote:
Test the crazy case that I describe in the .cc file.
Done. https://chromiumcodereview.appspot.com/9950095/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
