Please add more explanations of the change to the commit description.
https://chromiumcodereview.appspot.com/10007009/diff/1/src/profile-generator.cc File src/profile-generator.cc (right): https://chromiumcodereview.appspot.com/10007009/diff/1/src/profile-generator.cc#newcode2158 src/profile-generator.cc:2158: Object* value = target->IsJSGlobalPropertyCell() What happens to JSGlobalPropertyCells in a snapshot now? Are they connected to any node? https://chromiumcodereview.appspot.com/10007009/diff/1/src/profile-generator.cc#newcode2164 src/profile-generator.cc:2164: TagObject(value, "(hidden properties)"); Will there be only single entry with the name "hidden_properties"? https://chromiumcodereview.appspot.com/10007009/diff/1/src/profile-generator.cc#newcode3200 src/profile-generator.cc:3200: if (edge->from()->reachable_from_window()) return true; Why not: return edge->from()->reachable_from_window() || !edge->to()->reachable_from_window(); ? https://chromiumcodereview.appspot.com/10007009/diff/1/src/profile-generator.h File src/profile-generator.h (right): https://chromiumcodereview.appspot.com/10007009/diff/1/src/profile-generator.h#newcode602 src/profile-generator.h:602: unsigned reachable_from_window_: 1; Do we really need an additional field? It seems that 'painted_' bit is only used in FillPostorderIndexes. We can first fill the indexes, and then mark reachable objects, reusing the same bit. https://chromiumcodereview.appspot.com/10007009/diff/1/src/profile-generator.h#newcode1102 src/profile-generator.h:1102: void FillPostorderIndexes(Vector<HeapEntry*>* entries); Why the rename? "Reverse" means that children will have order indexes in reverse to their child index, as we are processing them backwards. https://chromiumcodereview.appspot.com/10007009/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
