LGTM

Please add more details to the description of the change before committing.


https://chromiumcodereview.appspot.com/10007009/diff/1/src/profile-generator.h
File src/profile-generator.h (right):

https://chromiumcodereview.appspot.com/10007009/diff/1/src/profile-generator.h#newcode602
src/profile-generator.h:602: unsigned reachable_from_window_: 1;
On 2012/04/06 10:04:36, alexeif wrote:
On 2012/04/05 22:00:13, Mikhail Naganov (Chromium) wrote:
> Do we really need an additional field? It seems that 'painted_' bit
is only
used
> in FillPostorderIndexes. We can first fill the indexes, and then
mark
reachable
> objects, reusing the same bit.
They both are in use in FillPostorderIndexes.

Sorry, didn't realize that. It is queried in IsRetainingEdge.

https://chromiumcodereview.appspot.com/10007009/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to