lgtm
https://chromiumcodereview.appspot.com/10031032/diff/6001/src/profile-generator.cc File src/profile-generator.cc (right): https://chromiumcodereview.appspot.com/10031032/diff/6001/src/profile-generator.cc#newcode1319 src/profile-generator.cc:1319: entries_->Add(EntryInfo(0, NULL)); Could you add a comment that it is for simplifying HeapObjectsMap::MoveObject ? https://chromiumcodereview.appspot.com/10031032/diff/6001/src/profile-generator.cc#newcode1377 src/profile-generator.cc:1377: ASSERT(static_cast<uint32_t>(entries_->length()) > entries_map_.occupancy()); Comment on why it is strictly greater? https://chromiumcodereview.appspot.com/10031032/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
