Overall looks good.
Please change in the description "to keep entries_ list in sorted by id
state"
-> "to keep 'entries_' list sorted by id"
https://chromiumcodereview.appspot.com/10031032/diff/6001/src/hashmap.h
File src/hashmap.h (right):
https://chromiumcodereview.appspot.com/10031032/diff/6001/src/hashmap.h#newcode65
src/hashmap.h:65: // Removes the entry with matching key.
Please update the comment.
https://chromiumcodereview.appspot.com/10031032/diff/6001/src/profile-generator.cc
File src/profile-generator.cc (right):
https://chromiumcodereview.appspot.com/10031032/diff/6001/src/profile-generator.cc#newcode1350
src/profile-generator.cc:1350: ASSERT(from != to);
I'm sure you will be hitting this assert. I think you should remove it.
https://chromiumcodereview.appspot.com/10031032/diff/6001/src/profile-generator.cc#newcode1373
src/profile-generator.cc:1373: ASSERT(entries_->length() == 1 ||
The first part seems to be superfluous, as if entries_ contains only the
dummy element, its id -- 0 will not exceed any other id.
https://chromiumcodereview.appspot.com/10031032/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
