http://codereview.chromium.org/10032029/diff/4001/src/hydrogen.cc File src/hydrogen.cc (right):
http://codereview.chromium.org/10032029/diff/4001/src/hydrogen.cc#newcode2639 src/hydrogen.cc:2639: BoundsCheckKey* Key() {return key_;} style-nit: add spaces after/before {}. http://codereview.chromium.org/10032029/diff/4001/src/hydrogen.cc#newcode2671 src/hydrogen.cc:2671: added_index_->InsertBefore(added_simulate); I think this is a little problematic and can be simplified: You only need an HSimulate if the HAdd has side-effects (i.e. if it is a tagged-add). In this case it is not safe to move it around in any case, since it can have side effects.) If you limit yourself to index expressions a[i+c] where the index i+c is an integer add (hadd->representation()->IsInteger32()), then you don't need to worry about the HSimulate at all and you can insert it anywhere without creating a new HSimulate. http://codereview.chromium.org/10032029/diff/4001/src/hydrogen.cc#newcode2682 src/hydrogen.cc:2682: BoundsCheckBbData(BoundsCheckKey* key, int32_t offset, HBasicBlock* bb, style-nit: One parameter pre line in definitions and declarations. http://codereview.chromium.org/10032029/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
