http://codereview.chromium.org/10032029/diff/14001/src/hydrogen.cc File src/hydrogen.cc (right):
http://codereview.chromium.org/10032029/diff/14001/src/hydrogen.cc#newcode2639 src/hydrogen.cc:2639: int32_t Offset() {return offset_;} Spaces around { and }. http://codereview.chromium.org/10032029/diff/14001/src/hydrogen.cc#newcode2650 src/hydrogen.cc:2650: Representation::Integer32()); Indentation. http://codereview.chromium.org/10032029/diff/14001/src/hydrogen.cc#newcode2694 src/hydrogen.cc:2694: Two empty lines here. http://codereview.chromium.org/10032029/diff/14001/src/hydrogen.cc#newcode2701 src/hydrogen.cc:2701: Two lines also here (and in other places between functions and classes) http://codereview.chromium.org/10032029/diff/14001/src/hydrogen.cc#newcode2705 src/hydrogen.cc:2705: return reinterpret_cast<BoundsCheckBbData**>(&(Lookup(key, I'd break the line before the &. I think it will be better readable. http://codereview.chromium.org/10032029/diff/14001/src/hydrogen.cc#newcode2738 src/hydrogen.cc:2738: // TODO(mmassi): allocate key only when we create a new table entry... To solve this TODO you can maybe consider making BoundsCheckKey BASE_EMBEDDED (i.e. not zone-allocated). Then you don't need to heap-allocate the space for it except when creating a new BoundsCheckBbData object. http://codereview.chromium.org/10032029/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
