https://chromiumcodereview.appspot.com/10086006/diff/1/src/profile-generator.cc File src/profile-generator.cc (right):
https://chromiumcodereview.appspot.com/10086006/diff/1/src/profile-generator.cc#newcode3303 src/profile-generator.cc:3303: if (children[i].type() == HeapGraphEdge::kShortcut) { On 2012/04/16 08:40:26, Mikhail Naganov (Chromium) wrote:
For the sake of clarity, I'd rename 'SetRootShortcutReference' to 'SetWindowReference' and add 'IsWindowReference' to filter out window
objects.
Otherwise, this construction is fragile.
Done. https://chromiumcodereview.appspot.com/10086006/diff/1/test/cctest/test-heap-profiler.cc File test/cctest/test-heap-profiler.cc (right): https://chromiumcodereview.appspot.com/10086006/diff/1/test/cctest/test-heap-profiler.cc#newcode156 test/cctest/test-heap-profiler.cc:156: printf("ALF: %d %d %d %d\n", x->GetSelfSize(), x1->GetSelfSize(), x2->GetSelfSize(), x->GetRetainedSize()); On 2012/04/16 08:40:26, Mikhail Naganov (Chromium) wrote:
Do you need this printf? Also, please mind the line length.
oops. fixed. https://chromiumcodereview.appspot.com/10086006/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
