On 2012/04/17 12:39:54, Yury Semikhatsky wrote:

https://chromiumcodereview.appspot.com/10110001/diff/2001/include/v8-profiler.h
File include/v8-profiler.h (right):


https://chromiumcodereview.appspot.com/10110001/diff/2001/include/v8-profiler.h#newcode568
include/v8-profiler.h:568: uint32_t index;
Please comment on the fields.


done.

https://chromiumcodereview.appspot.com/10110001/diff/2001/include/v8.h
File include/v8.h (right):


https://chromiumcodereview.appspot.com/10110001/diff/2001/include/v8.h#newcode3780
include/v8.h:3780: virtual WriteResult WriteHeapStatsChunk(HeapStatsUpdate*
data, int count) {
Is it ok to break existing API?

I've not committed the upstream code for this API yet.


https://chromiumcodereview.appspot.com/10110001/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to