LGTM, with comments

https://chromiumcodereview.appspot.com/10110001/diff/2001/include/v8-profiler.h
File include/v8-profiler.h (right):

https://chromiumcodereview.appspot.com/10110001/diff/2001/include/v8-profiler.h#newcode449
include/v8-profiler.h:449: * object. Updates on each time interval are
provided as a triplet. It has
"as a triplet. It has ..." -> "as a stream of the HeapStatsUpdate
structure instances."

https://chromiumcodereview.appspot.com/10110001/diff/2001/include/v8-profiler.h#newcode563
include/v8-profiler.h:563: * A struct for exporting HeapStats data from
V8, using "push" model.
Add "See HeapProfiler::PushHeapObjectsStats."

https://chromiumcodereview.appspot.com/10110001/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to