Hello Peter! I have reverted[1] your commit. It caused presubmit[2] failures. Also, please never commit against trunk directly. We only commit against bleeding_edge and do pushes to trunk twice a week.
For example Canary releases are built using top of trunk from the V8 repository. So you don't want to have changes land there immediately without letting them cycle through our build-bots before. [1] https://code.google.com/p/v8/source/detail?r=11377 [2] http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20trunk/builds/132/steps/Presubmit/logs/stdio Best regards, Michael On Wed, Apr 18, 2012 at 15:29, <[email protected]> wrote: > On 2012/04/18 12:36:09, Peter Rybin wrote: > >> https://chromiumcodereview.**appspot.com/10091022/diff/1/** >> src/mirror-debugger.js<https://chromiumcodereview.appspot.com/10091022/diff/1/src/mirror-debugger.js> >> File src/mirror-debugger.js (right): >> > > > https://chromiumcodereview.**appspot.com/10091022/diff/1/** > src/mirror-debugger.js#**newcode600<https://chromiumcodereview.appspot.com/10091022/diff/1/src/mirror-debugger.js#newcode600> > >> src/mirror-debugger.js:600: * Return the primitive value if this is >> object of >> Boolean, Number or String type (but not Date). >> On 2012/04/17 12:48:44, Yang wrote: >> > Please keep the 80 character limit. >> > > Sorry, too much programming in WebKit :) >> > > > https://chromiumcodereview.**appspot.com/10091022/diff/1/** > src/mirror-debugger.js#**newcode604<https://chromiumcodereview.appspot.com/10091022/diff/1/src/mirror-debugger.js#newcode604> > >> src/mirror-debugger.js:604: if (!IS_STRING_WRAPPER(this.**value_) && >> !IS_NUMBER_WRAPPER(this.value_**) && !IS_BOOLEAN_WRAPPER(this.**value_)) >> { >> On 2012/04/17 12:48:44, Yang wrote: >> > Ditto. >> > > Done. >> > > > https://chromiumcodereview.**appspot.com/10091022/diff/1/**src/runtime.cc<https://chromiumcodereview.appspot.com/10091022/diff/1/src/runtime.cc> >> File src/runtime.cc (right): >> > > > https://chromiumcodereview.**appspot.com/10091022/diff/1/** > src/runtime.cc#newcode12287<https://chromiumcodereview.appspot.com/10091022/diff/1/src/runtime.cc#newcode12287> > >> src/runtime.cc:12287: } >> >> On 2012/04/17 12:48:44, Yang wrote: >> > This seems to do the same as %_ValueOf (see FullCodeGenerator::** >> EmitValueOf). >> > > Done. >> > > LGTM. > > > https://chromiumcodereview.**appspot.com/10091022/<https://chromiumcodereview.appspot.com/10091022/> > > -- > v8-dev mailing list > [email protected] > http://groups.google.com/**group/v8-dev<http://groups.google.com/group/v8-dev> > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
