http://codereview.chromium.org/10263002/diff/1006/src/debug.h File src/debug.h (right):
http://codereview.chromium.org/10263002/diff/1006/src/debug.h#newcode487 src/debug.h:487: struct FramePaddingLayout { On 2012/05/02 11:38:34, Yang wrote:
we would typically define this as a class deriving from AllStatic
(e.g. class
ArgumentsAdaptorFrameConstants : public AllStatic)
Done. http://codereview.chromium.org/10263002/diff/1006/src/debug.h#newcode493 src/debug.h:493: static const int kFrameBaseSize = 4; On 2012/05/02 11:38:34, Yang wrote:
This coincides with Debug::kFrameDropperFrameSize, which is also 4. If
they are
derived similarly, can't we consistently use only one of the two?
I'm not sure. Both are derived from the fact that the minimum size of InternalFrame is 4 words. But they are layouts of different frames. So I would say it's still more of coincidence here. http://codereview.chromium.org/10263002/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
