On 2012/05/02 11:38:34, Yang wrote:
Integers are not always converted to Smis by a left-shift by one. While
we can
assume that on platform-dependent code (ia32, arm and mips), we avoid
using
that
assumption on platform-independent code because on x64 a Smi is converted
by a
left-shift by 32. Code that intend to store integers are Smis should
therefore
use Smi::FromInt() and Smi::cast()->value().
Thanks a lot for the very accurate review. I hope I addressed all your
comments.
Plus add added a test (currently disabled because if issue 915).
http://codereview.chromium.org/10263002/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
